Fix vertical centering of file tree icons and use entryIcon for submodules/symlinks #34137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Apr 7, 2025
wxiaoguang
reviewed
Apr 7, 2025
github-actions
bot
added
the
modifies/templates
wxiaoguang
reviewed
Apr 7, 2025
wxiaoguang
reviewed
Apr 7, 2025
lunny
approved these changes
Apr 7, 2025
GiteaBot
added
lgtm/need 1
|
BTW can we add 1 pixel more gap between icon an file name? From above screenshot: 
From 1.23 branch: 
|
silverwind
reviewed
Apr 8, 2025
silverwind
reviewed
Apr 8, 2025
Co-authored-by: silverwind <[email protected]>
done. |
silverwind
approved these changes
Apr 9, 2025
GiteaBot
added
lgtm/done
lunny
added
skip-changelog
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 14, 2025
* giteaofficial/main: (27 commits) fix github migration error when using multiple tokens (go-gitea#34144) Add package version api endpoints (go-gitea#34173) Fix incorrect file links (go-gitea#34189) Add cache for common package queries (go-gitea#22491) Allow admins and org owners to change org member public status (go-gitea#28294) Fix span svg layout (go-gitea#34185) fix webhook url (go-gitea#34186) Optimize overflow-menu (go-gitea#34183) Move and rename UpdateRepository (go-gitea#34136) Update milestones.tmpl (go-gitea#34184) [skip ci] Updated translations via Crowdin Refactor Git Attribute & performance optimization (go-gitea#34154) [skip ci] Updated translations via Crowdin fix(go-gitea#33711): cross-publish docker images to ghcr.io (go-gitea#34148) refactor organization menu (go-gitea#33928) feat: Add sorting by exclusive labels (issue priority) (go-gitea#33206) Fix vertical centering of file tree icons and use entryIcon for submodules/symlinks (go-gitea#34137) bugfix check for alternate ssh host certificate location (go-gitea#34146) Cache GPG keys, emails and users when list commits (go-gitea#34086) Set MERMAID_MAX_SOURCE_CHARACTERS to 50000 (go-gitea#34152) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the file tree, the icons are not vertically centered, which affects the overall visual consistency.
Currently, the icons of submodules and symlinks do not adopt the value of entryIcon, resulting in inconsistent icon display.
before:
after:
